-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Resource spec based on the move to the SDK and named tracers #421
Merged
bogdandrutu
merged 8 commits into
open-telemetry:master
from
tsloughter:sdk-resource-fix
Jan 30, 2020
Merged
update Resource spec based on the move to the SDK and named tracers #421
bogdandrutu
merged 8 commits into
open-telemetry:master
from
tsloughter:sdk-resource-fix
Jan 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsloughter
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
January 24, 2020 23:33
MrAlias
reviewed
Jan 25, 2020
MrAlias
reviewed
Jan 25, 2020
MrAlias
reviewed
Jan 25, 2020
MrAlias
reviewed
Jan 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Made some minor grammatical suggestions.
Co-Authored-By: Tyler Yahn <[email protected]>
Co-Authored-By: Tyler Yahn <[email protected]>
Co-Authored-By: Tyler Yahn <[email protected]>
MrAlias
approved these changes
Jan 25, 2020
carlosalberto
approved these changes
Jan 25, 2020
dyladan
reviewed
Jan 25, 2020
bobstrecansky
approved these changes
Jan 27, 2020
arminru
approved these changes
Jan 27, 2020
jmacd
approved these changes
Jan 27, 2020
jkwatson
reviewed
Jan 27, 2020
jkwatson
reviewed
Jan 27, 2020
jkwatson
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with the addition of one 'The'
Co-Authored-By: John Watson <[email protected]>
bogdandrutu
approved these changes
Jan 30, 2020
bogdandrutu
approved these changes
Jan 30, 2020
MikeGoldsmith
added a commit
to MikeGoldsmith/opentelemetry-specification
that referenced
this pull request
Feb 6, 2020
…elemetry-specification into remove-binary-format * 'remove-binary-format' of github.com:MikeGoldsmith/opentelemetry-specification: update Resource spec based on the move to the SDK and named tracers (open-telemetry#421) sdk-tracer: replace Factory with Provider (open-telemetry#422) Add details for determining the parent Span from a Context (open-telemetry#423)
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
…pen-telemetry#421) * update Resource spec based on the move to the SDK and named tracers * Update specification/sdk-resource.md Co-Authored-By: Tyler Yahn <[email protected]> * Update specification/sdk-resource.md Co-Authored-By: Tyler Yahn <[email protected]> * Update specification/sdk-resource.md Co-Authored-By: Tyler Yahn <[email protected]> * provide example of what the entity producing telemetry means * Update specification/sdk-resource.md Co-Authored-By: John Watson <[email protected]> Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: John Watson <[email protected]> Co-authored-by: Bogdan Drutu <[email protected]>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…pen-telemetry#421) * update Resource spec based on the move to the SDK and named tracers * Update specification/sdk-resource.md Co-Authored-By: Tyler Yahn <[email protected]> * Update specification/sdk-resource.md Co-Authored-By: Tyler Yahn <[email protected]> * Update specification/sdk-resource.md Co-Authored-By: Tyler Yahn <[email protected]> * provide example of what the entity producing telemetry means * Update specification/sdk-resource.md Co-Authored-By: John Watson <[email protected]> Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: John Watson <[email protected]> Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Resource spec was moved from the API to the SDK but it still referred to the API in the text. This also updates to reference the Providers and all the tracers that may be retrieved from the provider (named tracers and meters).